Skip to content
This repository was archived by the owner on Aug 1, 2021. It is now read-only.

Updates test instructions on Hello World's HINTS.md#350

Merged
matthewmorgan merged 1 commit into
exercism:masterfrom
joeljuca:updates-forgotten-test-instruction
May 7, 2017
Merged

Updates test instructions on Hello World's HINTS.md#350
matthewmorgan merged 1 commit into
exercism:masterfrom
joeljuca:updates-forgotten-test-instruction

Conversation

@joeljuca
Copy link
Copy Markdown
Contributor

@joeljuca joeljuca commented May 7, 2017

This PR refers to #349, which @ronalson reported that instructions to test exercises are just to run jasmine ., when it should actually be jasmine your-exercise-test-file.spec.js.

@matthewmorgan
Copy link
Copy Markdown
Contributor

@joelwallis thanks for doing this, and thanks to @ronalson for reporting the issue.

There is a way to configure jasmine to run all *spec* files in the current directory, but let's save that for another PR. @joelwallis I can open a new issue for that.

Closes #349

@matthewmorgan matthewmorgan merged commit 3b04fb4 into exercism:master May 7, 2017
@joeljuca joeljuca deleted the updates-forgotten-test-instruction branch May 7, 2017 14:04
@joeljuca
Copy link
Copy Markdown
Contributor Author

joeljuca commented May 7, 2017

I didn't know that it could be done through configuration. @matthewmorgan let's discuss it on a new issue for sure!

@ronalson
Copy link
Copy Markdown

ronalson commented May 7, 2017

Thank you guys for the quick response. This was my first ever issue reporting. I liked the experience and I'm looking forward to contribute even more in the future. :)

I have one question though: this merge takes immediate effect on exercises documentation or it will be available only in future version of the CLI. If it is immediate, how do I update previously downloaded content?

@joeljuca
Copy link
Copy Markdown
Contributor Author

joeljuca commented May 8, 2017

@ronalson awesome! You can take a look at available issues tagged as good first patch. Those are meant to serve as a good starting point for new contributors 🙂

@joeljuca
Copy link
Copy Markdown
Contributor Author

joeljuca commented May 8, 2017

About seeing the effects, they are definitely not immediate. I've just checked how Exercism CLI works and it fires HTTP requests to http://x.exercism.io/v2 - in this case, to the /exercises/:language-track/:exercise endpoint. I'm seeing outdated content, so language track contents might be cached by the API itself.

You can check it by yourself, running exercism --verbose fetch javascript hello-world.

@matthewmorgan
Copy link
Copy Markdown
Contributor

@joelwallis @ronalson there is a delay, as the UI app is redeployed on a periodic cycle. Once a day, I think? But not instant, for sure.

arthurchipdean pushed a commit to arthurchipdean/xjavascript that referenced this pull request May 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants