Skip to content
This repository was archived by the owner on Aug 1, 2021. It is now read-only.

Add info about how to install Javascript#348

Merged
matthewmorgan merged 3 commits into
exercism:masterfrom
onealexharms:patch-1
May 2, 2017
Merged

Add info about how to install Javascript#348
matthewmorgan merged 3 commits into
exercism:masterfrom
onealexharms:patch-1

Conversation

@onealexharms
Copy link
Copy Markdown
Contributor

So people don't have to go to stack overflow to get a link to that page like I did. :)

@fredosantana
Copy link
Copy Markdown

JS is a markup language similar to HTML and CSS. No installation needed in general.

https://www.w3schools.com/js/

@matthewmorgan
Copy link
Copy Markdown
Contributor

@onealexharms yes this can use clarification for sure! I think it might be worth explaining that JavaScript is interpreted by the V8 engine that is part of NodeJS, so installing Node gives us a JavaScript interpreter to run our tests and code.

Would you mind adding that to your PR?

@fredosantana unless you install NodeJS, it would be difficult to run the test suites for this track. Most modern OS's come with browsers installed, but I don't think they come with NodeJS installed, or any command-line JavaScript interpreter that I am aware of, so I think this PR has value.

@onealexharms
Copy link
Copy Markdown
Contributor Author

onealexharms commented May 1, 2017

@matthewmorgan The page I linked to covers installing Node and npm, then Jasmine, so I think there's nothing to add. Let me know if you disagree?

@matthewmorgan
Copy link
Copy Markdown
Contributor

@onealexharms I agree that the page that you linked to has all the needed information around setting up the environment. I was just wondering if a little context ahead of the link might be helpful, like:

You'll need a JavaScript interpreter to run the test suites. This comes bundled with NodeJS. For information about how to install these tools, see...

What do you think?

@onealexharms
Copy link
Copy Markdown
Contributor Author

Oh, I actually like your wording better, but I didn't look at it when I typed... Should I change it, do you think?

@matthewmorgan
Copy link
Copy Markdown
Contributor

Sure, why not! As long as we're changing it, let's do that. I'm glad you brought our attention to this, I don't think we'd even noticed it needed touching up.

@matthewmorgan matthewmorgan merged commit e5d82cf into exercism:master May 2, 2017
@matthewmorgan
Copy link
Copy Markdown
Contributor

💯 Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants