Repository navigation
🧪 Read the CommonMark spec fixtures as UTF-8 - #454
Open
Aschenbath wants to merge 2 commits into
Open
Aschenbath wants to merge 2 commits into
Aschenbath wants to merge 2 commits into
Conversation
`test_spec.py` and `get_cmark_spec.py` call `Path.read_text()` without an encoding, so on Windows with a non-UTF-8 locale (e.g. GBK on Chinese Windows) collecting the spec tests fails with UnicodeDecodeError and the whole module errors out. The fixtures are UTF-8, so read them as such. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows with a non-UTF-8 system locale (here: GBK, Chinese Windows), test collection for
tests/test_cmark_spec/test_spec.pyfails:Path.read_text()uses the locale encoding when none is given, but the spec fixtures are UTF-8. This passesencoding="utf-8"to the fourread_text()calls intest_spec.pyandget_cmark_spec.py. Test-only change.Verification (Windows 11, Python 3.12, locale cp936):
pytest tests→ 1032 passed (same result as running withPYTHONUTF8=1)Disclosure: this fix was found and written with an AI coding assistant (Claude Code) and verified by running the test suite as above.
🤖 Generated with Claude Code