Upgrade dependencies and fix linting issues.#105
Merged
Conversation
Member
|
Interesting. Hope it works. |
ejsmith
approved these changes
Feb 14, 2023
Member
ejsmith
left a comment
There was a problem hiding this comment.
LGTM
Looks like you've gotten better at TypeScript since you originally did this, eh? :-)
| }, | ||
| "scripts": { | ||
| "clean": "rimraf packages/*/dist example/*/dist", | ||
| "build": "lage build --no-cache --verbose --no-deps", |
Member
Author
|
I still need to come up with a solution for: stacktracejs/stacktrace.js#230 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: This pr addresses dependencies, we have a plan to solve this in the next update.
This should resolve all CJS import issues,
I think what was happening is that by default we were saying the main script was
index.js(https://github.com/exceptionless/Exceptionless.JavaScript/blob/master/packages/browser/package.json#L27) and that all consumers should use this and tree shake. The problem with this is that we had a dependency onstacktrace-jsand import forstacktrace-jsso it would always be loaded as a cjs umd module. If you used the bundled version transpiled with esbuild it would have worked.This pr has a prebuild action to convert the stacktrace-js dependency and it's dependencies to esm local file, the build then references this file instead of the cjs requires and then post build copies this transpiled file to the dist folder (tsc doesn't copy js files or any non ts file by default).