Get rid of {{ site.github.url }}#91
Conversation
|
@WasabiFan, take this for a spin. You can see the live preview (generated by |
|
Search is broken; make sure to update that as well. The search code uses URLs in two places: in |
There was a problem hiding this comment.
I cleaned up this mess and force pushed, so should be better now.
Yup, there if a TODO in publish.rb for that 😉 |
I haven't gotten that far in the diff yet 😉 I'm multitasking |
3dfe7bd to
1f2d1ed
Compare
|
It doesn't look like the atom feed was changed; you may or may not want to change that, depending on the behavior you're looking for. |
There was a problem hiding this comment.
You could do {{ site.github | jsonify }} instead here to get the whole hierarchy
There was a problem hiding this comment.
Cool. This file is not actually used at the moment though.
|
I figured that the atom feed needed absolute urls, so I left them. And I figured that it didn't matter if it work anywhere else. If it ever gives us trouble, github recently allowed jekyll-feed. But, if it ain't broke, don't fix it. |
There was a problem hiding this comment.
Looks like this assumes that you're on master... it should check the current branch instead I suppose
There was a problem hiding this comment.
again, this is starting with a new empty git repository in a temporary directory. Assuming master is 100% safe unless there is a way to locally configure git to use another name for the default branch in a new empty repository.
|
Looks good. Once you merge this, I can update my CI branch from master and modify the script to work for my needs there. If you have already configured command-line parsing at that point, the changes should be fairly trivial. Although, now that I think about it, maybe this script shouldn't publish by default -- it would just create the files. Then you could add |
|
Oh, and we will need to update the project publishing tutorial for these changes; you just won't be able to preview your changes unless you want to do it on the command line. |
* Also get rid of absolute links to http://www.ev3dev.org * Introduce publish.rb script to publish to personal gh-pages branch (this was the whole reason for using site.github.url in the first place) Fixes ev3dev#90
(this was the whole reason for using site.github.url in the first place)
Fixes #90