Skip to content

Update publish.rb to replace URL links in CSS#163

Merged
dlech merged 1 commit into
ev3dev:masterfrom
WasabiFan:add-css-link-replacement
May 21, 2016
Merged

Update publish.rb to replace URL links in CSS#163
dlech merged 1 commit into
ev3dev:masterfrom
WasabiFan:add-css-link-replacement

Conversation

@WasabiFan
Copy link
Copy Markdown
Member

@WasabiFan WasabiFan commented May 20, 2016

Fixes #135.

I have published to my fork, so you can check there for the results. The CSS file with the fixed links is here.

@WasabiFan
Copy link
Copy Markdown
Member Author

WasabiFan commented May 20, 2016

Uh-oh, looks like I broke something with one of my last changes. Fixing now.

All better.

@WasabiFan WasabiFan force-pushed the add-css-link-replacement branch from 91717f7 to b25f85d Compare May 20, 2016 05:27
Comment thread publish.rb Outdated
Dir.chdir tmp
system "git init"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why adding whitespace here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some test code here. It's a good practice as far as I am concerned to have whitespace on blank lines between code anyway, so I kept it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git complains about trailing whitespace of any sort, so I prefer to never have trailing whitespace if at all possible. All of the editors I use nowadays are smart enough that they will indent correctly without having to leave whitespace on empty lines like this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add the whitespace because it makes it much easier to copy-and-paste to those blank lines, especially when I include a newline in my copied code.

Whatever the case, I'll remove it -- I don't have strong feelings either way and see no reason to fight about inconsequential whitespace. Braces, however, are a different story... 😉

@WasabiFan WasabiFan force-pushed the add-css-link-replacement branch from b25f85d to 98a08e0 Compare May 20, 2016 18:19
@WasabiFan
Copy link
Copy Markdown
Member Author

Amended to remove whitespace (some of which was not initially added with these changes).

@dlech dlech merged commit 84407f8 into ev3dev:master May 21, 2016
@dlech
Copy link
Copy Markdown
Member

dlech commented May 21, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

glyphicons broken when previewing site with publish.rb

2 participants