Skip to content

Adding TLS-PSK authentication method via function callback. #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oberdorc wants to merge 18 commits into from
Closed

Adding TLS-PSK authentication method via function callback. #333

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cf3ed74
Added TLS-PSK authentication method via function callback.
oberdorc Mar 2, 2024
9a27ce0
Update README.md
oberdorc Mar 2, 2024
cd3968b
Update README.md
oberdorc Mar 2, 2024
e8cf540
Update webserver.cpp
oberdorc Mar 3, 2024
f336fec
Update webserver.cpp
oberdorc Mar 3, 2024
0e24af6
Update webserver.cpp
oberdorc Mar 3, 2024
d6d0c47
Update webserver.cpp
oberdorc Mar 3, 2024
2c46df5
Update minimal_https_psk.cpp
oberdorc Mar 5, 2024
c60071d
Update Makefile.am
oberdorc Mar 12, 2024
5eb1f03
Added conditional for Gnu TLS.
oberdorc Mar 12, 2024
beb7732
Update Makefile.am
oberdorc Mar 12, 2024
7f79202
Update minimal_https_psk.cpp
oberdorc Mar 13, 2024
454447f
Update create_webserver.hpp
oberdorc Mar 13, 2024
6db4099
Update webserver.cpp
oberdorc Mar 13, 2024
e069f45
Update minimal_https_psk.cpp
oberdorc Mar 13, 2024
dfe3045
Update create_webserver.hpp
oberdorc Mar 13, 2024
5b98977
Update minimal_https_psk.cpp
oberdorc Mar 14, 2024
1400946
Update webserver.cpp
oberdorc Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update webserver.cpp 
Address an error that _key_ in the static PSK handler function is assigned a value that is never used in the case if the Gnu TLS libary is not present, i.e. HAVE_GNUTLS has not been defined.

The intended behavior is such that calling the static callback handler function of the webserver guarantees that the user registered callback function is invoked.
  • Loading branch information
@oberdorc
oberdorc authored Mar 3, 2024
commit f336fecfefb5fc81fee374e5fb65746a43f80bb7
2 changes: 1 addition & 1 deletion src/webserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ void webserver::sweet_kill() {
}

void webserver::psk_cred_handler_func(void* cls, const struct MHD_Connection*, const char* username, void** psk, size_t* psk_size) {
std::string key = std::invoke(static_cast<const webserver*>(cls)->psk_cred_handler,username);
[[maybe_unused]] std::string key = std::invoke(static_cast<const webserver*>(cls)->psk_cred_handler,username);

#ifdef HAVE_GNUTLS
*psk_size = key.length();
Expand Down