Repository navigation
Expand tests of resource resolution - #309
Merged
Merged
Conversation
bcsgh
commented
Apr 6, 2023
Comment on lines
+386
to
+390
| #ifdef CASE_INSENSITIVE | ||
| LT_CHECK_EQ(true, ws->register_resource("ok", &ok2)); | ||
| #else | ||
| LT_CHECK_EQ(false, ws->register_resource("ok", &ok2)); | ||
| #endif |
Contributor
Author
There was a problem hiding this comment.
After a bit more digging, I think these are actually backwards. And both in fact end up returning false.
tl;dr: http_endpoint::operator < is unconditionally case-insensitive:
libhttpserver/src/details/http_endpoint.cpp
Lines 144 to 146 in 6d1df06
That's going to be a pain to fix as it's something users could be inadvertently depending on.
Also add a comment that the non `-DCASE_INSENSITIVE` testcases is probably wrong.
Really this should be assigned to an issue report, not a person, because nobody has agreed to fix it yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some more test for resource resolution.
This includes