Removed strlen from generate_random_upload_filename

As Codacy static code analysis warns about the safety issue of strlen if a given string is not terminated, this is removed. The solution uses the size of the original string, which is just duplicated to a char* as the used function _mktemp_s requires a char* which will be changed by the function and the changed result is needed afterwards.
etr · etr · Mar 3, 2022 · Feb 8, 2022 · Feb 9, 2022 · Feb 10, 2022
commit ccc67e87f86fa26e04db41ed7403eaf3541f15ea
diff --git a/src/http_utils.cpp b/src/http_utils.cpp
@@ -234,12 +234,8 @@ const std::string http_utils::generate_random_upload_filename(const std::string&
     char *template_filename = strdup(filename.c_str());
     int fd = 0;
 
-    if (template_filename == NULL) {
-        throw std::exception();
-    }
-
 #if defined(_WIN32)
-    if (0 != _mktemp_s(template_filename, strlen(template_filename) + 1)) {
+    if (0 != _mktemp_s(template_filename, filename.size() + 1)) {
         free(template_filename);
         throw std::exception();
     }