Repository navigation
Remove --build option from bootstrap - #254
Merged
Merged
Conversation
It was unused and did not work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
boostrap fails when passed the '--build' option. This is because it goes in conflict with the requirement to build in a separate directory.
See: #253
Description of the Change
Given that the feature is mostly unused, this change removes it.
Alternate Designs
We could have fixed the feature at the cost of additional complexity.
Possible Drawbacks
Customers that were using this feature as part of their build system might see a failure in the upcoming version - albeit this seems hard given that the feature doesn't work. Converting to run the additional steps is simple enough.
Verification Process
CI/CD.
Release Notes
Removed '--build' option from the bootstrap script.