Adapted sleep function in 'examples/deferred_with_accumulator.cpp' for non-*Nix#157
Merged
etr merged 1 commit intoetr:masterfrom Aug 14, 2019
Merged
Adapted sleep function in 'examples/deferred_with_accumulator.cpp' for non-*Nix#157etr merged 1 commit intoetr:masterfrom
etr merged 1 commit intoetr:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
======================================
Coverage 95.3% 95.3%
======================================
Files 35 35
Lines 3197 3197
======================================
Hits 3047 3047
Misses 150 150Continue to review full report at Codecov.
|
Owner
|
Thanks for fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#156
Description of the Change
Modified deferred_with_accumulator.cpp example
Added thread, chrono headers. Changed sleep() function to C++11
Alternate Designs
#ifdef Windows hack: https://stackoverflow.com/a/10918411/234826
Possible Drawbacks
Might add infinitesimal overhead for Unix systems compared to using straight sleep()
Verification Process
Checked on MinGW64 and Ubuntu x64
Release Notes
Replaced sleep function with C++11 equivalent.