Skip to content

Add setting to enable TCP-NODELAY (disables Nagle's algo) - #153

Merged
etr merged 3 commits into
masterfrom
nodelay
Aug 9, 2019
Merged

etr merged 3 commits into
masterfrom
nodelay

Conversation

@etr

@etr etr commented Aug 9, 2019

Copy link
Copy Markdown
Owner

Description of the Change

Added parameter to the webserver to enable the TCP-NODELAY flag on the webserver.

Verification Process

Integration Tests

Release Notes

Added parameter to the webserver to enable the TCP-NODELAY flag on the webserver.

@etr etr added performance Related to performance. api Related to libhttpserver's public APIs. labels Aug 9, 2019
@etr etr self-assigned this Aug 9, 2019
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #153 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   95.26%   95.31%   +0.04%     
==========================================
  Files          34       35       +1     
  Lines        3169     3200      +31     
==========================================
+ Hits         3019     3050      +31     
  Misses        150      150
Impacted Files Coverage Δ
src/webserver.cpp 90.5% <100%> (+0.1%) ⬆️
test/integ/nodelay.cpp 100% <100%> (ø)
src/httpserver/create_webserver.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d77ac5...f578654. Read the comment docs.

@etr
etr merged commit cce5227 into master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to libhttpserver's public APIs. performance Related to performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants