Repository navigation
Conversation
avrc_defs.h has some scattered U+0092 characters in it for apostrophes. Replace them with standard U+0027 apostrophes. The U+0092 apostrophes somehow caused invalid UTF-8 in https://github.com/zephyrproject-rtos/esp-idf, though it seems to be fine here. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
ulfalizer
added a commit
to ulfalizer/esp-idf-1
that referenced
this pull request
Jan 25, 2020
Corresponding upstream PR (though it's just the weird apostrophes there, not invalid UTF-8): espressif/esp-idf#4667 Fixes issues while grepping for #defines, in a new test. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
Collaborator
|
Thanks for reporting and sorry for the slow turnaround. Sorry that we are now during the holiday of Chinese Lunar New Year. Will update to you when we are back, thanks. |
|
Hi, @ulfalizer Thanks for your code. But unfortunately, we have fixed the same annotation error in one MR in our internal repo. Due to the Chinese Spring Festival, the sync. into GitHub is slower than usual. Thanks again for contributing to this PR, and we will close the PR and notify you when the fix is on GitHub. Thanks |
|
|
Collaborator
|
@ulfalizer Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avrc_defs.h has some scattered U+0092 characters in it for apostrophes.
Replace them with standard U+0027 apostrophes.
The U+0092 apostrophes somehow caused invalid UTF-8 in
https://github.com/zephyrproject-rtos/esp-idf, though it seems to be
fine here.