Open
Conversation
…spnet into espnet3/recipe/asr_ls100
for more information, see https://pre-commit.ci
…pnet into espnet3/recipe/asr_ls100
for more information, see https://pre-commit.ci
- I forgot to fix run.py - I think we need to have run.py in template, and symlink to recipes?
…pnet into espnet3/recipe/asr_ls100
…erence
- train.py: Update module docstring to be generic ('ESPnet3 systems')
- system.py: Fix load_function example to use dot notation instead of colon
- inference_provider.py: Fix parameter name 'cfg' to 'config' in build_model docstring
- sentencepiece.py: Fix parameter name 'output_path' to 'save_path' and default
character_coverage from 0.9995 to 1.0 in train_sentencepiece docstring
Minor docstring fixes
I noticed that there is currently no mechanism to configure hyperparameters that control the inference-path. With this settings users can put hyper parameters for these settings directly from the config file.
- Insert special token after the last token if insert_after is not specified.
…t into espnet3/package_files
…t into espnet3/demo_stage
- To avoid user confusion - Avoid config collisions; multiple-iterator require extra config that’s bug‑prone. - It also can’t map different shards to different GPUs
- Shards are not properly distributed to multiple GPUs.
- DataOrganizer generates an error without preprocessor
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
|
This pull request is now in conflict :( |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6342 +/- ##
==========================================
- Coverage 69.33% 0 -69.34%
==========================================
Files 760 0 -760
Lines 70099 0 -70099
==========================================
- Hits 48601 0 -48601
+ Misses 21498 0 -21498
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you change?
Added demo stage.
pack_demo,upload_demofor BaseSystem.Why did you make this change?
Automatic generation of models are very important for easily open-source and easily sharing the research outcome.
Since it uses the code and configs for the inference stage, ESPnet3 can generate demos for not only espnet-2-based pretrained models, but also user-defined custom models.
Is your PR small enough?
No, it is larger than 20 file changes.
This is because it adds
espnet3/demo/package and corresponding unit tests, also adding new CI job for UI tests that requires various files including recipe-side changes and templates.Additional Context
This PR should be merged after #6339.