Changed order of boards in boards.txt and boards.txt.py#7625
Closed
bonnom wants to merge 2 commits into
Closed
Conversation
The order of board names was a giant mess. The order is now first generic esp8266 and esp8285, followed by all other boards sorted in alphabetical order.
The order of board names was a giant mess. The order is now first generic esp8266 and esp8285, followed by all other boards sorted in alphabetical order.
Author
|
I don't know why boards.txt failed. I generated the boards.txt on my own computer with python. |
Collaborator
|
You need to regen the boards.txt using any changes you've made to boards.txt.py and make it part of the commit. You also need to make sure that any changes you've made are stable (i.e. don't rely on unguaranteed ordering of Python lists/maps/etc.). At a higher level, why are you suggesting this reordering? The two files are only machine read and not for human consumption... |
Collaborator
|
Closing due to build errors and lack of feedback. If you have an update and can explain the reasoning for doing this, please drop a note here and we can reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of board names was a giant mess. The order is now first generic esp8266 and esp8285, followed by all other boards sorted in alphabetical order.