Ability to define -DFP_IN_IROM when generating ld script#7188
Merged
Conversation
earlephilhower
approved these changes
Apr 6, 2020
Collaborator
earlephilhower
left a comment
There was a problem hiding this comment.
LGTM, but unfortunately I'm not a PIO user so can't comment if this is the best way to get another flag in.
mhightower83
reviewed
Apr 6, 2020
| join(FRAMEWORK_DIR, "tools", "sdk", "ld", "eagle.app.v6.common.ld.h"), | ||
| env.VerboseAction( | ||
| "$CC -CC -E -P -D%s $SOURCE -o $TARGET" % current_vtables, | ||
| "$CC -CC -E -P -D%s %s $SOURCE -o $TARGET" % (current_vtables, fp_in_irom), |
Contributor
There was a problem hiding this comment.
I don't speak pythonese or use platformio; however, shouldn't there be a -D in front of the new '%s'.
Déjà Vu, I changed the same line in a PoC PR
Arduino/tools/platformio-build.py
Line 274 in 91fc391
Contributor
Author
There was a problem hiding this comment.
No, because the second parameter can be absent. This would result in -D being inserted and potentially causing an error.
The -D is already included above here: fp_in_irom = "-DFP_IN_IROM"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #7180, there was no way to enable the
-DFP_IN_IROMflag when generating the ld script.