Skip to content

Set SPI_HAS_TRANSACTION to 1#6591

Merged
earlephilhower merged 2 commits into
esp8266:masterfrom
Lauszus:SPI_HAS_TRANSACTION
Oct 5, 2019
Merged

Set SPI_HAS_TRANSACTION to 1#6591
earlephilhower merged 2 commits into
esp8266:masterfrom
Lauszus:SPI_HAS_TRANSACTION

Conversation

@Lauszus

@Lauszus Lauszus commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

See #2639

@earlephilhower earlephilhower left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just checked the AVR definition and it does set it to 1, not just define it.

https://github.com/arduino/ArduinoCore-avr/blob/master/libraries/SPI/src/SPI.h

@earlephilhower earlephilhower added this to the 2.6.0 milestone Oct 4, 2019
@earlephilhower earlephilhower merged commit 5d20137 into esp8266:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants