Allow Filesystem update via ESP8266HTTPUpdateServer#3732
Conversation
This adds capability to update the SPIFFS image via the same mechansism as firmware in the ESP8266HTTPUpdateServer. It does not provide any dependency or linkage between firmware and spiffs image updating; they are each taken on their own, each followed by a reboot. (I wrote this before seeing the other PR for similar functionality; I like this a bit better, becaue it uses the available SPIFFS size, and does not hide magic numbers (U_SPIFFS) in the html...) (It also cleans up a stray \n from commit ace0622)
# Conflicts: # libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer.cpp
|
I'm using this feature for a while and it works great! |
|
I think it deserves a little more explanation here... |
|
@devyte , would you mind to look into this PR? |
|
Hi @igrr |
|
Just for curiosity, does this PR have no importance at all? |
|
@caverna it's important, I may include this in my own application. We're just prioritizing stability for 2.4.1 and likely 2.5.0 as well, which means complex enhancements like this one get pushed back a little. Please be patient, we'll get there. |
|
Ok, the library has changed a lot... |
|
It was |
|
Hi @d-a-v ! |
|
Symbols _Fs_end and _Fs_start aren't defined. |
|
They are declared in flash_hal.h |
earlephilhower
left a comment
There was a problem hiding this comment.
Seems like a good idea, thanks for updating it to the new core!
|
@earlephilhower sorry, I typed your user wrong in comments... :-) |
earlephilhower
left a comment
There was a problem hiding this comment.
Seems good to me, thanks.
|
@d-a-v please let me know if it's necessary to rename internal variables and/or html parameter name. |
|
@caverna Yes it seems @earlephilhower is right and names could be more generic |
This is a fix for #3234 from @sandeen
The original description is:
This adds capability to update the SPIFFS image via the same mechanism as firmware in the ESP8266HTTPUpdateServer.
It does not provide any dependency or linkage between firmware and spiffs image updating; they are each taken on their own, each followed by a reboot.
(I wrote this before seeing the other PR #2701 for similar functionality; I like this a bit better, because it uses the available SPIFFS size, and does not hide magic numbers (U_SPIFFS) in the html...)
(It also cleans up a stray \n from commit ace0622)
We'd really like to see this functionality in the library for the OpenEVSE wifi project
This is my first try at this, mostly cribbing from the ESP8266httpUpdate version of the updater - happy to fix up anything as needed.
Thanks,
-Eric