Store git version of the core in the compiled binary#2099
Merged
Conversation
72f864e to
d6e0355
Compare
Current coverage is 42.60%@@ master #2099 diff @@
==========================================
Files 19 19
Lines 3634 3634
Methods 328 328
Messages 0 0
Branches 585 585
==========================================
+ Hits 956 1548 +592
+ Misses 2513 2086 -427
+ Partials 165 0 -165
|
d6e0355 to
12ff7a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ESP.getCoreVersion()bashandgit)Adds
ARDUINO_ESP8266_RELEASE_XYZdefine which can be used in#ifdef...statements (i.e. ARDUINO_ESP8266_RELEASE_2_3_0_RC1)Core git version is stored at known offset in binary, so eboot will also report git version during startup (next to the last line):
Same caveats apply for this, i.e. it prints "v00000000" on Windows and prints "vffffffff" if there is no .git folder in the core directory.
Relies on platform.txt so doesn't work with Platoform.IO. May or may not work with Eclipse Arduino plugin (not tested). Should work work makeEspArduino (not tested).