Fix: nested indenting for offsetTernaryExpressions: true (fixes #13971) (#13972)

Chris Brody · sheerun · web-flow · commit e1da90fc414a · 2021-01-29T22:32:22.000-05:00
* reproduce extra nested ternary indentation with a test

* add a similar test with proper indenting of nested ternary

* apply condition to avoid extra indenting with offsetTernaryExpressions

Co-authored-by: Adam Stankiewicz &lt;sheerun@sher.pl&gt;

Co-authored-by: Adam Stankiewicz &lt;sheerun@sher.pl&gt;
diff --git a/lib/rules/indent.js b/lib/rules/indent.js
@@ -1178,6 +1178,7 @@ module.exports = {
                     offsets.setDesiredOffset(colonToken, firstToken, 1);
 
                     offsets.setDesiredOffset(firstConsequentToken, firstToken,
+                        firstConsequentToken.type === "Punctuator" &&
                         options.offsetTernaryExpressions ? 2 : 1);
 
                     /*
diff --git a/tests/lib/rules/indent.js b/tests/lib/rules/indent.js
@@ -2204,6 +2204,26 @@ ruleTester.run("indent", rule, {
             `,
             options: [4, { offsetTernaryExpressions: true }]
         },
+        {
+            code: unIndent`
+              condition1
+                ? condition2
+                  ? Promise.resolve(1)
+                  : Promise.resolve(2)
+                : Promise.resolve(3)
+            `,
+            options: [2, { offsetTernaryExpressions: true }]
+        },
+        {
+            code: unIndent`
+              condition1
+                ? Promise.resolve(1)
+                : condition2
+                  ? Promise.resolve(2)
+                  : Promise.resolve(3)
+            `,
+            options: [2, { offsetTernaryExpressions: true }]
+        },
         {
             code: unIndent`
               condition
