Update: check ternary : even if ? was reported in space-infix-ops (#13963)

mdjermanovic · web-flow · commit 1a078b9166f2 · 2021-01-30T04:22:13.000+01:00
diff --git a/lib/rules/space-infix-ops.js b/lib/rules/space-infix-ops.js
@@ -132,7 +132,9 @@ module.exports = {
 
             if (nonSpacedConsequentNode) {
                 report(node, nonSpacedConsequentNode);
-            } else if (nonSpacedAlternateNode) {
+            }
+
+            if (nonSpacedAlternateNode) {
                 report(node, nonSpacedAlternateNode);
             }
         }
diff --git a/tests/lib/rules/space-infix-ops.js b/tests/lib/rules/space-infix-ops.js
@@ -161,15 +161,69 @@ ruleTester.run("space-infix-ops", rule, {
         },
         {
             code: "a?b:c",
-            output: "a ? b:c",
-            errors: [{
-                messageId: "missingSpace",
-                data: { operator: "?" },
-                type: "ConditionalExpression",
-                line: 1,
-                column: 2,
-                endColumn: 3
-            }]
+            output: "a ? b : c",
+            errors: [
+                {
+                    messageId: "missingSpace",
+                    data: { operator: "?" },
+                    type: "ConditionalExpression",
+                    line: 1,
+                    column: 2,
+                    endColumn: 3
+                },
+                {
+                    messageId: "missingSpace",
+                    data: { operator: ":" },
+                    type: "ConditionalExpression",
+                    line: 1,
+                    column: 4,
+                    endColumn: 5
+                }
+            ]
+        },
+        {
+            code: "a? b :c",
+            output: "a ? b : c",
+            errors: [
+                {
+                    messageId: "missingSpace",
+                    data: { operator: "?" },
+                    type: "ConditionalExpression",
+                    line: 1,
+                    column: 2,
+                    endColumn: 3
+                },
+                {
+                    messageId: "missingSpace",
+                    data: { operator: ":" },
+                    type: "ConditionalExpression",
+                    line: 1,
+                    column: 6,
+                    endColumn: 7
+                }
+            ]
+        },
+        {
+            code: "a ?b: c",
+            output: "a ? b : c",
+            errors: [
+                {
+                    messageId: "missingSpace",
+                    data: { operator: "?" },
+                    type: "ConditionalExpression",
+                    line: 1,
+                    column: 3,
+                    endColumn: 4
+                },
+                {
+                    messageId: "missingSpace",
+                    data: { operator: ":" },
+                    type: "ConditionalExpression",
+                    line: 1,
+                    column: 5,
+                    endColumn: 6
+                }
+            ]
         },
         {
             code: "a?b : c",

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,9 @@ module.exports = {`
`132`	`132`
`133`	`133`	`if (nonSpacedConsequentNode) {`
`134`	`134`	`report(node, nonSpacedConsequentNode);`
`135`		`- } else if (nonSpacedAlternateNode) {`
	`135`	`+ }`
	`136`	`+`
	`137`	`+ if (nonSpacedAlternateNode) {`
`136`	`138`	`report(node, nonSpacedAlternateNode);`
`137`	`139`	`}`
`138`	`140`	`}`