Add typeshed submodule and pass it down to LS (microsoft#2043)

Mikhail Arkhipov · web-flow · commit 7a90e863c174 · 2018-06-25T11:55:22.000-07:00
* LS symbol providers

* Typeshed paths

* Typeshed submodule

* Add submodule
diff --git a/.gitmodules b/.gitmodules
@@ -0,0 +1,4 @@
+[submodule "typeshed"]
+	path = typeshed
+	url = https://github.com/python/typeshed.git
+	branch = master
diff --git a/package.json b/package.json
@@ -1173,6 +1173,15 @@
                     "description": "Controls appearance of methods with double underscores in the completion list.",
                     "scope": "resource"
                 },
+                "python.autoComplete.typeshedPaths": {
+                    "type": "array",
+                    "items": {
+                        "type": "string"
+                    },
+                    "default": [],
+                    "description": "Specifies paths to local typeshed repository clone(s) for the Python language server.",
+                    "scope": "resource"
+                },
                 "python.disableInstallationCheck": {
                     "type": "boolean",
                     "default": false,
diff --git a/src/client/activation/analysis.ts b/src/client/activation/analysis.ts
@@ -190,7 +190,7 @@ export class AnalysisExtensionActivator implements IExtensionActivator {
             const interpreterDataService = new InterpreterDataService(this.context, this.services);
             interpreterData = await interpreterDataService.getInterpreterData();
         } catch (ex) {
-            this.appShell.showErrorMessage('Unable to determine path to the Python interpreter. IntelliSense will be limited.');
+            this.appShell.showWarningMessage('Unable to determine path to the Python interpreter. IntelliSense will be limited.');
         }
 
         this.interpreterHash = interpreterData ? interpreterData.hash : '';
@@ -204,13 +204,16 @@ export class AnalysisExtensionActivator implements IExtensionActivator {
             properties['PrefixPath'] = interpreterData.prefix;
         }
 
-        let searchPaths = interpreterData ? interpreterData.searchPaths : '';
+        let searchPathsString = interpreterData ? interpreterData.searchPaths : '';
+        let typeshedPaths: string[] = [];
+
         const settings = this.configuration.getSettings();
         if (settings.autoComplete) {
             const extraPaths = settings.autoComplete.extraPaths;
             if (extraPaths && extraPaths.length > 0) {
-                searchPaths = `${searchPaths};${extraPaths.join(';')}`;
+                searchPathsString = `${searchPathsString};${extraPaths.join(';')}`;
             }
+            typeshedPaths = settings.autoComplete.typeshedPaths;
         }
 
         // tslint:disable-next-line:no-string-literal
@@ -219,9 +222,13 @@ export class AnalysisExtensionActivator implements IExtensionActivator {
         // Make sure paths do not contain multiple slashes so file URIs
         // in VS Code (Node.js) and in the language server (.NET) match.
         // Note: for the language server paths separator is always ;
-        searchPaths = searchPaths.split(path.delimiter).map(p => path.normalize(p)).join(';');
+        const searchPaths = searchPathsString.split(path.delimiter).map(p => path.normalize(p));
         // tslint:disable-next-line:no-string-literal
-        properties['SearchPaths'] = `${searchPaths};${pythonPath}`;
+        properties['SearchPaths'] = `${searchPaths.join(';')};${pythonPath}`;
+
+        if (!typeshedPaths || typeshedPaths.length === 0) {
+            typeshedPaths = [path.join(this.context.extensionPath, 'typeshed')];
+        }
 
         const selector = [{ language: PYTHON, scheme: 'file' }];
         const excludeFiles = this.getExcludedFiles();
@@ -245,6 +252,8 @@ export class AnalysisExtensionActivator implements IExtensionActivator {
                     trimDocumentationText: false,
                     maxDocumentationTextLength: 0
                 },
+                searchPaths,
+                typeStubSearchPaths: typeshedPaths,
                 asyncStartup: true,
                 excludeFiles: excludeFiles,
                 testEnvironment: isTestExecution()
diff --git a/src/client/common/configSettings.ts b/src/client/common/configSettings.ts
@@ -233,7 +233,8 @@ export class PythonSettings extends EventEmitter implements IPythonSettings {
             extraPaths: [],
             addBrackets: false,
             preloadModules: [],
-            showAdvancedMembers: false
+            showAdvancedMembers: false,
+            typeshedPaths: []
         };
 
         // tslint:disable-next-line:no-backbone-get-set-outside-model no-non-null-assertion
diff --git a/src/client/common/types.ts b/src/client/common/types.ts
@@ -221,6 +221,7 @@ export interface IAutoCompleteSettings {
     readonly extraPaths: string[];
     readonly preloadModules: string[];
     readonly showAdvancedMembers: boolean;
+    readonly typeshedPaths: string[];
 }
 export interface IWorkspaceSymbolSettings {
     readonly enabled: boolean;
@@ -237,6 +238,7 @@ export interface ITerminalSettings {
 }
 export interface IPythonAnalysisEngineSettings {
     readonly showAdvancedMembers: boolean;
+    readonly typeshedPaths: string[];
 }
 
 export const IConfigurationService = Symbol('IConfigurationService');
diff --git a/typeshed b/typeshed
@@ -0,0 +1 @@
+Subproject commit 95eff73ab2092f2c3158198d404a921447172418

Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,7 @@ export interface IAutoCompleteSettings {`
`221`	`221`	`readonly extraPaths: string[];`
`222`	`222`	`readonly preloadModules: string[];`
`223`	`223`	`readonly showAdvancedMembers: boolean;`
	`224`	`+ readonly typeshedPaths: string[];`
`224`	`225`	`}`
`225`	`226`	`export interface IWorkspaceSymbolSettings {`
`226`	`227`	`readonly enabled: boolean;`
`@@ -237,6 +238,7 @@ export interface ITerminalSettings {`
`237`	`238`	`}`
`238`	`239`	`export interface IPythonAnalysisEngineSettings {`
`239`	`240`	`readonly showAdvancedMembers: boolean;`
	`241`	`+ readonly typeshedPaths: string[];`
`240`	`242`	`}`
`241`	`243`
`242`	`244`	`export const IConfigurationService = Symbol('IConfigurationService');`