Make ActionInterface use ServerRequestInterface#85
Merged
Conversation
Although ActionHandler deals exclusively with ServerRequestInterface instead of RequestInterface, ActionInterface used just RequestInterface. This made it impossible for actions to use the helpful features that ServerRequestInterface offers. In particular, this bug actually rendered the example Action code in the docs incorrect, because the variable $request (of type RequestInterface) was passed as a parameter to input(), which expected ServerRequestInterface.
Contributor
|
@bvisness Not sure I'd say it's impossible. It's still possible, albeit not necessarily ideal, to do this: public function __invoke(
RequestInterface $request, ResponseInterface $response)
{
if (!$request instanceof ServerRequestInterface) {
// Throw some sort of error or some such here
}
}Changing this signature would be a breaking change. If we decide to release it, the above approach can be used in the interim. |
Contributor
Author
|
@elazar |
Contributor
|
👍 |
Contributor
|
I don't know of any situation where Equip would be used with client requests, so this makes perfect sense. If it ends up being a problem for people, we can change it. |
jeichorn
pushed a commit
to pagely/framework
that referenced
this pull request
Jun 17, 2021
Although ActionHandler deals exclusively with ServerRequestInterface instead of RequestInterface, ActionInterface used just RequestInterface. This made it impossible for actions to use the helpful features that ServerRequestInterface offers. In particular, this bug actually rendered the example Action code in the docs incorrect, because the variable $request (of type RequestInterface) was passed as a parameter to input(), which expected ServerRequestInterface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although ActionHandler deals exclusively with ServerRequestInterface
instead of RequestInterface, ActionInterface used just
RequestInterface. This made it impossible for actions to use the
helpful features that ServerRequestInterface offers.
In particular, this bug actually rendered the example Action code in
the docs incorrect, because the variable $request (of type
RequestInterface) was passed as a parameter to input(), which expected
ServerRequestInterface.