Skip to content

Do not hang forever if test server fails to start #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akx wants to merge 2 commits into
base: master
Choose a base branch
from
+31 −4
Open

Do not hang forever if test server fails to start #3775

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65e2d86
Catch errors from TestServer (instead of hanging if `server.started` …
akx Feb 24, 2026
8a959d8
Do not wait forever for test server to start or stop
akx Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Catch errors from TestServer (instead of hanging if server.started … 
…never becomes true)
  • Loading branch information
@akx
akx committed Feb 24, 2026
commit 65e2d866625d8834258d49d947db4700150f3c29
21 changes: 19 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,11 +269,28 @@ async def watch_restarts(self) -> None: # pragma: no cover


def serve_in_thread(server: TestServer) -> typing.Iterator[TestServer]:
thread = threading.Thread(target=server.run)
server_exception = None
server_caught_exception = threading.Event()

def _run_server() -> None:
nonlocal server_exception
try:
server.run()
except BaseException as exc: # pragma: nocover
# BaseException as we need to catch SystemExit too;
# `uvicorn` calls `sys.exit(1)` at failure.
server_exception = exc
server_caught_exception.set()

thread = threading.Thread(target=_run_server)
thread.start()

try:
while not server.started:
time.sleep(1e-3)
if server_caught_exception.wait(1e-3):
raise RuntimeError(
f"Server failed to start: {server_exception!r}",
) from server_exception
yield server
finally:
server.should_exit = True
Expand Down