Skip to content

FloatField will crash if the input is a number that is too big#8725

Merged
auvipy merged 6 commits into
encode:masterfrom
winmorre:floatfield-crush/#8716
Nov 22, 2022
Merged

FloatField will crash if the input is a number that is too big#8725
auvipy merged 6 commits into
encode:masterfrom
winmorre:floatfield-crush/#8716

Conversation

@winmorre
Copy link
Copy Markdown
Contributor

@winmorre winmorre commented Oct 21, 2022

Fix for #8716

@winmorre winmorre force-pushed the floatfield-crush/#8716 branch from bfc1638 to 9aee257 Compare October 21, 2022 08:57
@kevin-brown
Copy link
Copy Markdown
Contributor

kevin-brown commented Oct 22, 2022

This seems fairly reasonable. Is it possible to get an added unit test to cover this case? Also does this apply to other field types or is this unique to floats?

@winmorre
Copy link
Copy Markdown
Contributor Author

winmorre commented Oct 22, 2022

This seems fairly reasonable. Is it possible to get an added unit test to cover this case? Also does this apply to other field types or is this unique to floats?

I will add some unit test and also check if other fields have similar issue

@winmorre
Copy link
Copy Markdown
Contributor Author

winmorre commented Oct 22, 2022

This seems fairly reasonable. Is it possible to get an added unit test to cover this case? Also does this apply to other field types or is this unique to floats?

I will add some unit test and also check if other fields have similar issue

I have added a unit test for the floatfield overflow error.
Tried replicating this for both DecimalField and IntegerField but they worked fine with large data inputs.

kevin-brown
kevin-brown reviewed Oct 24, 2022
View reviewed changes
Comment thread tests/test_fields.py Outdated
@auvipy auvipy added the Bug label Nov 22, 2022
auvipy
auvipy requested changes Nov 22, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor wording adjustments only

Comment thread rest_framework/fields.py Outdated
auvipy
auvipy requested changes Nov 22, 2022
View reviewed changes
Comment thread tests/test_fields.py Outdated
@auvipy auvipy merged commit 9e56f54 into encode:master Nov 22, 2022
@auvipy
Copy link
Copy Markdown
Collaborator

auvipy commented Nov 22, 2022

thanks a lot both of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auvipy auvipy auvipy approved these changes

+1 more reviewer

@kevin-brown kevin-brown kevin-brown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@winmorre @kevin-brown @auvipy