Skip to content

Correctly handle calls setting timestamp to 0#23310

Merged
hoodmane merged 9 commits intoemscripten-core:mainfrom
hoodmane:set-timestamp-to-0
Jan 9, 2025
Merged

Correctly handle calls setting timestamp to 0#23310
hoodmane merged 9 commits intoemscripten-core:mainfrom
hoodmane:set-timestamp-to-0

Conversation

@hoodmane
Copy link
Copy Markdown
Collaborator

@hoodmane hoodmane commented Jan 6, 2025

If someone calls utimes("file", 0, 0) the previous code I wrote would not adjust the time stamp.

If someone calls `utimes("file", 0, 0)` the previous code I wrote would
not adjust the time stamp.
@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented Jan 6, 2025

Test?

@hoodmane
Copy link
Copy Markdown
Collaborator Author

hoodmane commented Jan 6, 2025

I added it to test_futimens but of course running that on nodefs detected more problems to fix.

This is an automatic change generated by tools/maint/rebaseline_tests.py.

The following (18) test expectation files were updated by
running the tests with `--rebaseline`:

```
other/codesize/test_codesize_cxx_ctors1.gzsize: 8365 => 8374 [+9 bytes / +0.11%]
other/codesize/test_codesize_cxx_ctors1.jssize: 20373 => 20391 [+18 bytes / +0.09%]
other/codesize/test_codesize_cxx_ctors2.gzsize: 8347 => 8358 [+11 bytes / +0.13%]
other/codesize/test_codesize_cxx_ctors2.jssize: 20341 => 20359 [+18 bytes / +0.09%]
other/codesize/test_codesize_cxx_except.gzsize: 9369 => 9377 [+8 bytes / +0.09%]
other/codesize/test_codesize_cxx_except.jssize: 24141 => 24159 [+18 bytes / +0.07%]
other/codesize/test_codesize_cxx_except_wasm.gzsize: 8328 => 8340 [+12 bytes / +0.14%]
other/codesize/test_codesize_cxx_except_wasm.jssize: 20267 => 20285 [+18 bytes / +0.09%]
other/codesize/test_codesize_cxx_except_wasm_exnref.gzsize: 8328 => 8340 [+12 bytes / +0.14%]
other/codesize/test_codesize_cxx_except_wasm_exnref.jssize: 20267 => 20285 [+18 bytes / +0.09%]
other/codesize/test_codesize_cxx_lto.gzsize: 8360 => 8371 [+11 bytes / +0.13%]
other/codesize/test_codesize_cxx_lto.jssize: 20397 => 20415 [+18 bytes / +0.09%]
other/codesize/test_codesize_cxx_mangle.gzsize: 9374 => 9384 [+10 bytes / +0.11%]
other/codesize/test_codesize_cxx_mangle.jssize: 24142 => 24160 [+18 bytes / +0.07%]
other/codesize/test_codesize_cxx_noexcept.gzsize: 8365 => 8374 [+9 bytes / +0.11%]
other/codesize/test_codesize_cxx_noexcept.jssize: 20373 => 20391 [+18 bytes / +0.09%]
other/codesize/test_codesize_files_js_fs.gzsize: 7655 => 7665 [+10 bytes / +0.13%]
other/codesize/test_codesize_files_js_fs.jssize: 18867 => 18885 [+18 bytes / +0.10%]

Average change: +0.10% (+0.07% - +0.14%)
```
Comment thread src/library_nodefs.js Outdated
Comment thread src/library_workerfs.js Outdated
@hoodmane hoodmane merged commit 25dea46 into emscripten-core:main Jan 9, 2025
@hoodmane hoodmane deleted the set-timestamp-to-0 branch January 9, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants