Check in generated struct info rather than auto-generating it in the sysroot. NFC#19013
Conversation
df8c126 to
1e00330
Compare
1e00330 to
16cc723
Compare
|
IIUC this means that we need to manually run that |
|
In general this sounds good, but I have the feeling we didn't do it this way for a reason that I can't remember... |
Right, although for local development you still had to remember to do something like I'll update the docs. |
2a2b9ef to
f8e5054
Compare
e592dae to
ce5658f
Compare
…root. NFC I noticed while working `gen_sig_info.py` in #18985 that is was simpler to just keep a copy of the generated file checked into source control. We can use a unit test check that its up-to-date on each commit. In fact we already had a unit test that was doing this and keeping a copy of the expected output in the test directory. This simplifies the emcc linker code since we can always assume the presence of the struct info file. Also allows us to remove the `varies=False` special case in cache logic.
ce5658f to
854f498
Compare
I noticed while working
gen_sig_info.pyin #18985 that is was simpler to just keep a copy of the generated file checked into source control. We can use a unit test check that its up-to-date on each commit. In fact we already had a unit test that was doing this and keeping a copy of the expected output in the test directory.This simplifies the emcc linker code since we can always assume the presence of the struct info file.