Initial testing building as C module#36
Merged
Merged
Conversation
0284c26 to
119da09
Compare
For example in micropython/ports/unix make -j4 USER_C_MODULES=/home/jon/projects/emlearn-micropython/src/ Note that right now there is a -Wdouble-promotion failure in eml_trees.h
Fixes some compile warnigs that are errors in MicroPython user C modules
fc7c6cb to
2c12d56
Compare
Right now there are some duplicated symbols from eml_common.h when built together with emlearn_trees
2c12d56 to
d2731f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module setup is slightly different for an external C module compared to dyamic native module. But for now it seems that it might be possible to support both ways of building in a rather clean way.
References #18
Depends on emlearn/emlearn#110