Skip to content

[ENHANCEMENT blueprints] Fix ember-cli-htmlbars-inline-precompile deprecation - #8875

Merged
rwjblue merged 1 commit into
ember-cli:releasefrom
HeroicEric:silence-hbs-precompile-warning
Oct 7, 2019
Merged

[ENHANCEMENT blueprints] Fix ember-cli-htmlbars-inline-precompile deprecation#8875
rwjblue merged 1 commit into
ember-cli:releasefrom
HeroicEric:silence-hbs-precompile-warning

Conversation

@HeroicEric

@HeroicEric HeroicEric commented Oct 5, 2019

Copy link
Copy Markdown
Contributor
  • Drops ember-cli-htmlbars-inline-precompile from both app and addon blueprints
  • Bumps ember-cli-htmlbars from 4.0.1 to 4.0.5

Why?

Currently, generating a new ember app or addon and running it will result in the following deprecation:

DEPRECATION: ember-cli-htmlbars-inline-precompile is no longer needed with ember-cli-htmlbars versions 4.0.0 and higher, please remove it from `/Users/eric/code/foo/package.json`

See ember-cli/ember-cli-htmlbars#317 for more details.

Steps to reproduce the current issue:

$ npm install -g ember-cli
$ ember new foo-app
$ cd foo-app
$ ember s
DEPRECATION: ember-cli-htmlbars-inline-precompile is no longer needed with ember-cli-htmlbars versions 4.0.0 and higher, please remove it from `/Users/eric/code/foo/package.json`

- Drops `ember-cli-htmlbars-inline-precompile` from both app and addon
  blueprints
- Bumps `ember-cli-htmlbars` from
  [4.0.1](https://github.com/ember-cli/ember-cli-htmlbars/releases/tag/v4.0.1)
  to [4.0.5](https://github.com/ember-cli/ember-cli-htmlbars/releases/tag/v4.0.5)

Why?

Currently, generating a new ember app or addon and running it will
result in the following deprecation:

```
DEPRECATION: ember-cli-htmlbars-inline-precompile is no longer needed with ember-cli-htmlbars versions 4.0.0 and higher, please remove it from `/Users/eric/code/foo/package.json`
```

See ember-cli/ember-cli-htmlbars#317
for more details.

Steps to reproduce the current issue:

```bash
npm install -g ember-cli
ember new foo-app
cd foo-app
ember s
```
@rwjblue
rwjblue changed the base branch from master to release October 7, 2019 14:45
@rwjblue
rwjblue force-pushed the silence-hbs-precompile-warning branch from af4e3b0 to f3fbf1d Compare October 7, 2019 14:46
@rwjblue

rwjblue commented Oct 7, 2019

Copy link
Copy Markdown
Member

Updated PR to target release branch and rebased.

rwjblue commented Oct 7, 2019

Copy link
Copy Markdown
Member

(thank you @HeroicEric!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants