[ENHANCEMENT blueprints] Fix ember-cli-htmlbars-inline-precompile deprecation - #8875
Merged
rwjblue merged 1 commit intoOct 7, 2019
Merged
Conversation
- Drops `ember-cli-htmlbars-inline-precompile` from both app and addon blueprints - Bumps `ember-cli-htmlbars` from [4.0.1](https://github.com/ember-cli/ember-cli-htmlbars/releases/tag/v4.0.1) to [4.0.5](https://github.com/ember-cli/ember-cli-htmlbars/releases/tag/v4.0.5) Why? Currently, generating a new ember app or addon and running it will result in the following deprecation: ``` DEPRECATION: ember-cli-htmlbars-inline-precompile is no longer needed with ember-cli-htmlbars versions 4.0.0 and higher, please remove it from `/Users/eric/code/foo/package.json` ``` See ember-cli/ember-cli-htmlbars#317 for more details. Steps to reproduce the current issue: ```bash npm install -g ember-cli ember new foo-app cd foo-app ember s ```
rwjblue
force-pushed
the
silence-hbs-precompile-warning
branch
from
October 7, 2019 14:46
af4e3b0 to
f3fbf1d
Compare
Member
|
Updated PR to target |
Member
|
(thank you @HeroicEric!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember-cli-htmlbars-inline-precompilefrom both app and addon blueprintsember-cli-htmlbarsfrom 4.0.1 to 4.0.5Why?
Currently, generating a new ember app or addon and running it will result in the following deprecation:
See ember-cli/ember-cli-htmlbars#317 for more details.
Steps to reproduce the current issue: