blueprints(testem): --disable-background-networking for Chrome - #11036
Draft
ro0gr wants to merge 1 commit into
Draft
blueprints(testem): --disable-background-networking for Chrome#11036ro0gr wants to merge 1 commit into
--disable-background-networking for Chrome#11036ro0gr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have the exact scientific evidence for why it's needed, but it fixed focus-based tests in my CI yesterday. Hopefully, this change will save someone else's day in the future.
I suspect that in rare scenarios,
--disable-background-networkingmight cause focus to be stolen from browser elements or affect timings. Either way, it seems like an undesirable side effect in isolated environments like CI.This flag is also a default in Puppeteer, Playwright, and likely others.
I’ve left this as a draft to gather initial feedback. Let me know if I can help move it forward.