[ENHANCEMENT] Warn when ember destroy finds no files to remove#11007
Open
ashurHQ wants to merge 1 commit into
Open
[ENHANCEMENT] Warn when ember destroy finds no files to remove#11007ashurHQ wants to merge 1 commit into
ashurHQ wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8499.
Why
ember destroypreviously gave no feedback when it failed to remove files because the blueprint or entity didn't match anything on disk. The CLI would print "uninstalling " and other progress lines as if everything succeeded, leaving users wondering whether the command actually worked.What changed
processFilesForUninstallnow emits a yellow warning when the blueprint has files defined but none of them exist on disk. The warning names the blueprint and entity so users can see exactly what didn't match.Why per-blueprint instead of per-file
The TypeScript-undecided code path in
processFilesForUninstallpushes both the.tsand.jsvariants of each expected output into the candidate list, since only one of them will actually exist on disk. A per-file "not-found" warning would always print a false positive for whichever variant didn't match. Aggregating to "did this blueprint find anything to remove?" sidesteps that cleanly without needing TS-pair tracking.Test plan
tests/acceptance/destroy-test.jscoversember destroy blueprint does-not-existagainst a fresh app and asserts the warning lands in the output.Acceptance: ember destroysuite still passes.