fix: ensure --lang option requires a value#10877
Open
AyushKashyapII wants to merge 2 commits intoember-cli:masterfrom
Open
fix: ensure --lang option requires a value#10877AyushKashyapII wants to merge 2 commits intoember-cli:masterfrom
AyushKashyapII wants to merge 2 commits intoember-cli:masterfrom
Conversation
Author
|
Hi @kategengler , I hope you are having a good week! I just wanted to gently follow up on this PR regarding the fix for the I know this is a busy time of year, but whenever you have a moment, I would appreciate a review. Please let me know if there are any other changes required! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
newcommand previously allowed the--langflag to be passed without a value (e.g.,ember new my-app --lang), resulting in the project being created with an empty language string.This PR adds a check to ensure that if
--langis present, it must have a value. If not, it rejects with aSilentError.Reproduction
ember new my-app --langSolution
Added a validation check in
lib/commands/new.jsand a corresponding unit test intests/unit/commands/new-test.js.