Skip to content

Temporarily skip failing ember new test for npm versions <= v6.0.0 #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kellyselden merged 1 commit into from
Oct 4, 2022
Merged

Temporarily skip failing ember new test for npm versions <= v6.0.0 #10043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/acceptance/new-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
'use strict';

const execa = require('execa');
const semver = require('semver');
const fs = require('fs-extra');
const ember = require('../helpers/ember');
const walkSync = require('walk-sync');
Expand Down Expand Up @@ -270,6 +272,13 @@ describe('Acceptance: ember new', function () {
});

it('ember new with shorthand git blueprint and ref checks out the blueprint with the correct ref and uses it', async function () {
// Temporarily skipped for npm versions <= v6.0.0.
// See https://github.com/npm/cli/issues/4896 for more info.
let { stdout: npmVersion } = await execa('npm', ['-v']);
if (semver.major(npmVersion) <= 6) {
this.skip();
}

this.timeout(20000); // relies on GH network stuff

await ember([
Expand Down