[BUGFIX] Handle rebuild failures without exiting#10013
Merged
kellyselden merged 2 commits intoember-cli:lts-3-28from Oct 4, 2022
Merged
[BUGFIX] Handle rebuild failures without exiting#10013kellyselden merged 2 commits intoember-cli:lts-3-28from
kellyselden merged 2 commits intoember-cli:lts-3-28from
Conversation
Member
|
@kellyselden I think we need to cherry pick #9914 as well if we want CI to pass. |
When a rebuild fails, mark it as a builder failure so the watcher doesn't re-throw it, causing it to be an unhandled error that results in the process exiting. Fixes ember-cli#9584
If the most recent build failed and an HTTP request came in, the history middleware would throw an uncaught exception causing the process to exit. Instead, catch and ignore.
81d7320 to
241e1a8
Compare
bertdeblock
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picking #9987 into lts-3-28.