Implement a simple shouldComponentUpdate for DNDRoomTile#6313
Merged
lukebarnard1 merged 2 commits intodevelopfrom Mar 15, 2018
Merged
Implement a simple shouldComponentUpdate for DNDRoomTile#6313lukebarnard1 merged 2 commits intodevelopfrom
lukebarnard1 merged 2 commits intodevelopfrom
Conversation
because otherwise beautiful dnd spends a lot of time requesting animation frames pointlessly.
dbkr
approved these changes
Mar 14, 2018
Member
dbkr
left a comment
There was a problem hiding this comment.
lgtm, although in this case (and probably the other case actually) do you not just want to extend PureComponent?
Contributor
Author
oh. I've not used it before but sounds like a better plan. |
Member
|
re-lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because otherwise beautiful dnd spends a lot of time requesting
animation frames pointlessly.
a continuation of matrix-org/matrix-react-sdk#1801
mitigates #6060