Remove useless app preloading from Jitsi widget wrapper#12836
Merged
Remove useless app preloading from Jitsi widget wrapper#12836
Conversation
We should always have conference information, and if we don't then the widget is invalid.
Member
Author
|
cc @t3chguy - this is how we avoid the weird platform bugs. |
jryans
approved these changes
Mar 24, 2020
| import SdkConfig from "matrix-react-sdk/src/SdkConfig"; | ||
| import { loadConfig, preparePlatform } from "../initial-load"; | ||
|
|
||
| // Dev note: we use raw JS without many dependencies to reduce bundle size. |
Collaborator
There was a problem hiding this comment.
Can you file a future backlog issue for the bundle size? (It seems the Jitsi bundle is quite large currently.)
t3chguy
added a commit
that referenced
this pull request
Oct 17, 2024
* Update tests for new unsupported browser view Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add new desktop_builds config options Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should always have conference information, and if we don't then the widget is invalid.
Soft dependency on matrix-org/matrix-react-sdk#4252