Cherry pick node fix for ChildProcess.fork --eval bug#9132
Merged
kevinsawicki merged 3 commits intomasterfrom Apr 6, 2017
Merged
Cherry pick node fix for ChildProcess.fork --eval bug#9132kevinsawicki merged 3 commits intomasterfrom
kevinsawicki merged 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in nodejs/node#11958 which fixed nodejs/node#11948
Fix landed upstream in nodejs/node@9ff7ed2 and this was cherry-picked into our node fork as electron/node@3fe90cf
This patch can be dropped once we upgrade to Node 7.8
/cc @bpasero
Closes #8944