build: remove deps_add_v8_object_setinternalfieldfornodecore.patch#46992
Merged
codebytere merged 1 commit intomainfrom May 8, 2025
Merged
Conversation
This was a Node 20-specific workaround that's no longer needed in Node 22. Xref: nodejs/node#49874.
codebytere
approved these changes
May 8, 2025
|
No Release Notes |
Contributor
|
I was unable to backport this PR to "36-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #46998 |
Contributor
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
…lectron#46992) chore: remove deps_add_v8_object_setinternalfieldfornodecore.patch This was a Node 20-specific workaround that's no longer needed in Node 22. Xref: nodejs/node#49874.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This was a Node 20-specific workaround. I think it's no longer needed in Node v22?
Xref: nodejs/node#49874.
Checklist
npm testpassesRelease Notes
Notes: none.