Skip to content

fix: remove obsoleted --inspect-brk logic#46560

Merged
codebytere merged 1 commit intomainfrom
fix-resolvedargv
Apr 9, 2025
Merged

fix: remove obsoleted --inspect-brk logic#46560
codebytere merged 1 commit intomainfrom
fix-resolvedargv

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Apr 8, 2025 •
edited
Loading

Description of Change

Closes #46491.
Refs nodejs/node#55679

Removes logic made redundant in https://github.com/nodejs/node/pull/55679/files.

Checklist

Release Notes

Notes: Fixed an issue with --inspect-brk failing in packaged apps.

@codebytere codebytere requested a review from a team as a code owner April 8, 2025 10:30
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Apr 8, 2025
@codebytere codebytere added semver/patch backwards-compatible bug fixes ci-flake ⭕️ Issues specific to CI flakes, not bugs, if a bug happens to be related to a CI flake merge them target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. labels Apr 8, 2025
@codebytere codebytere changed the title chore: remove obsoleted --inspect-brk logic fix: remove obsoleted --inspect-brk logic Apr 8, 2025
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Apr 9, 2025
@codebytere codebytere merged commit 45a0494 into main Apr 9, 2025
56 checks passed
@codebytere codebytere deleted the fix-resolvedargv branch April 9, 2025 13:35
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Apr 9, 2025

Release Notes Persisted

Fixed an issue with --inspect-brk failing in packaged apps.

This was referenced Apr 9, 2025
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Apr 9, 2025

I have automatically backported this PR to "35-x-y", please check out #46583

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Apr 9, 2025

I have automatically backported this PR to "36-x-y", please check out #46584

@trop trop Bot added in-flight/35-x-y in-flight/36-x-y merged/36-x-y PR was merged to the "36-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. and removed target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. in-flight/36-x-y in-flight/35-x-y labels Apr 9, 2025
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@codebytere @kigh-ota
fix: remove obsoleted --inspect-brk logic (electron#46560)
fceab35 
fix: remove obsoleted --inspect-brk logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

No one assigned

Labels

ci-flake ⭕️ Issues specific to CI flakes, not bugs, if a bug happens to be related to a CI flake merge them merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot start distribution app with --inspect-brk flag

2 participants

@codebytere @ckerr