chore: bump chromium to 136.0.7053.1 (main) by electron-roller[bot] · Pull Request #45906 · electron/electron

electron-roller · 2025-03-06T13:00:33Z

Updating Chromium to 136.0.7053.1.

See all changes in 135.0.7049.7..136.0.7053.1

Notes: Updated Chromium to 136.0.7053.1.

https://chromium-review.googlesource.com/c/chromium/src/+/6318359 patch applied manually due to context shear

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6318420 patch applied manually due to context shear

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6326575 patch applied manually due to context shear

…mium-review.googlesource.com/c/chromium/src/+/6326236

…der_support:user_agent | https://chromium-review.googlesource.com/c/chromium/src/+/6244461

ckerr · 2025-03-07T03:49:36Z

+This patch can be removed after an upstream fix lands in Node.js,
+e.g. in https://github.com/nodejs/node-v8/tree/canary


upgrade-followup task: #45913

ckerr · 2025-03-07T03:50:58Z

+Presumably this is failing in this Chromium roll due to a
+clang version bump.
+
+We should remove this patch after upstreaming it.


Upstream PR: nodejs/node#57354

…ttps://chromium-review.googlesource.com/c/chromium/src/+/6313744

…ps://chromium-review.googlesource.com/c/chromium/src/+/6314545

…) | https://chromium-review.googlesource.com/c/chromium/src/+/6317362

…tps://chromium-review.googlesource.com/c/chromium/src/+/6308998

…ttps://chromium-review.googlesource.com/c/chromium/src/+/6295214 NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc

This is showing up in an eslint build step in Electron: > /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts > 77:23 error This assertion is unnecessary since the receiver accepts the original type of the expression @typescript-eslint/no-unnecessary-type-assertion > > ✖ 1 problem (1 error, 0 warnings) > 1 error and 0 warnings potentially fixable with the `--fix` option. However, removing the assertion causes a typescript build failure: > gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'. > Type 'null' is not assignable to type 'HTMLElement'. > > 77 items.indexOf(this.querySelector<HTMLElement>(':focus')); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ So I think the two different steps may be picking up typescript definitions. This patch should be removed after the issue is tracked down and fixed in a followup task.

Fixes this warning: > 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull] > 2025-03-07T01:05:01.8638267Z 257 | return nullptr; > 2025-03-07T01:05:01.8638481Z | ^~~~~~~ > 2025-03-07T01:05:01.8638700Z 1 error generated. Not sure why this warning was never triggered before; `git blame` indicates this code hasn't changed in ages: > c40a8273ef2 (Michaël Zasso 2024-05-10 09:50:20 +0200 255) #endif // DEBUG > 8e2d33f1562 (Anna Henningsen 2018-06-07 16:54:29 +0200 256) } > 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257) return nullptr; > 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258) } Presumably this is failing in this Chromium roll due to a clang version bump. We should remove this patch after upstreaming it.

ckerr · 2025-03-07T06:26:05Z

+So I think the two different steps may be picking up typescript definitions.
+
+This patch should be removed after the issue is tracked down
+andfixed in a followup task.


upgrades followup task: #45914

dsanders11 · 2025-03-07T16:09:10Z

+Not sure why this warning was never triggered before; `git blame`
+indicates this code hasn't changed in ages:


Looks like std::string(nullptr) was undefined behavior prior to C++23 which closed the gap. The Chromium folks were discussing that particular change and after they discussed with libc++ folks on Discord it was updated to start warning about it.

release-clerk · 2025-03-07T17:36:02Z

Release Notes Persisted

Updated Chromium to 136.0.7053.1.

* chore: bump chromium in DEPS to 136.0.7052.0 * chore: update mas_avoid_private_macos_api_usage.patch.patch https://chromium-review.googlesource.com/c/chromium/src/+/6318359 patch applied manually due to context shear * chore: update preconnect_manager.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6318420 patch applied manually due to context shear * chore: e patches all * chore: bump chromium to 136.0.7053.1 * chore: update fix_remove_profiles_from_spellcheck_service.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6326575 patch applied manually due to context shear * chore: e patches all * chore: revert removal of v8 API used by Node.js * devtools: Remove DevToolsUIBindings::SendJsonRequest() | https://chromium-review.googlesource.com/c/chromium/src/+/6326236 * 6244461: Merge //content/common/user_agent.cc into //components/embedder_support:user_agent | https://chromium-review.googlesource.com/c/chromium/src/+/6244461 * 6313744: Migrate views::Background factory methods to ColorVariant | https://chromium-review.googlesource.com/c/chromium/src/+/6313744 * 6314545: Remove multiple argument support from base::ToString() | https://chromium-review.googlesource.com/c/chromium/src/+/6314545 * 6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab() | https://chromium-review.googlesource.com/c/chromium/src/+/6317362 * 6308998: Add SettingAccess structured metrics event for DevTools | https://chromium-review.googlesource.com/c/chromium/src/+/6308998 * 6295214: Remove redundant state field in per-extension preferences | https://chromium-review.googlesource.com/c/chromium/src/+/6295214 NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc * fix: ui/ linter error This is showing up in an eslint build step in Electron: > /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts > 77:23 error This assertion is unnecessary since the receiver accepts the original type of the expression @typescript-eslint/no-unnecessary-type-assertion > > ✖ 1 problem (1 error, 0 warnings) > 1 error and 0 warnings potentially fixable with the `--fix` option. However, removing the assertion causes a typescript build failure: > gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'. > Type 'null' is not assignable to type 'HTMLElement'. > > 77 items.indexOf(this.querySelector<HTMLElement>(':focus')); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ So I think the two different steps may be picking up typescript definitions. This patch should be removed after the issue is tracked down and fixed in a followup task. * fix: -Wnonnull warning Fixes this warning: > 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull] > 2025-03-07T01:05:01.8638267Z 257 | return nullptr; > 2025-03-07T01:05:01.8638481Z | ^~~~~~~ > 2025-03-07T01:05:01.8638700Z 1 error generated. Not sure why this warning was never triggered before; `git blame` indicates this code hasn't changed in ages: > c40a8273ef2 (Michaël Zasso 2024-05-10 09:50:20 +0200 255) #endif // DEBUG > 8e2d33f1562 (Anna Henningsen 2018-06-07 16:54:29 +0200 256) } > 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257) return nullptr; > 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258) } Presumably this is failing in this Chromium roll due to a clang version bump. We should remove this patch after upstreaming it. * docs: add upstream pr link for Node patch --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> (cherry picked from commit 458b14b)

chore: fix patch shear

* chore: bump chromium to 135.0.7049.7 (main) (#45900) chore: bump chromium in DEPS to 135.0.7049.7 (cherry picked from commit bb1c3df) * chore: bump chromium to 136.0.7053.1 (main) (#45906) * chore: bump chromium in DEPS to 136.0.7052.0 * chore: update mas_avoid_private_macos_api_usage.patch.patch https://chromium-review.googlesource.com/c/chromium/src/+/6318359 patch applied manually due to context shear * chore: update preconnect_manager.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6318420 patch applied manually due to context shear * chore: e patches all * chore: bump chromium to 136.0.7053.1 * chore: update fix_remove_profiles_from_spellcheck_service.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6326575 patch applied manually due to context shear * chore: e patches all * chore: revert removal of v8 API used by Node.js * devtools: Remove DevToolsUIBindings::SendJsonRequest() | https://chromium-review.googlesource.com/c/chromium/src/+/6326236 * 6244461: Merge //content/common/user_agent.cc into //components/embedder_support:user_agent | https://chromium-review.googlesource.com/c/chromium/src/+/6244461 * 6313744: Migrate views::Background factory methods to ColorVariant | https://chromium-review.googlesource.com/c/chromium/src/+/6313744 * 6314545: Remove multiple argument support from base::ToString() | https://chromium-review.googlesource.com/c/chromium/src/+/6314545 * 6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab() | https://chromium-review.googlesource.com/c/chromium/src/+/6317362 * 6308998: Add SettingAccess structured metrics event for DevTools | https://chromium-review.googlesource.com/c/chromium/src/+/6308998 * 6295214: Remove redundant state field in per-extension preferences | https://chromium-review.googlesource.com/c/chromium/src/+/6295214 NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc * fix: ui/ linter error This is showing up in an eslint build step in Electron: > /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts > 77:23 error This assertion is unnecessary since the receiver accepts the original type of the expression @typescript-eslint/no-unnecessary-type-assertion > > ✖ 1 problem (1 error, 0 warnings) > 1 error and 0 warnings potentially fixable with the `--fix` option. However, removing the assertion causes a typescript build failure: > gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'. > Type 'null' is not assignable to type 'HTMLElement'. > > 77 items.indexOf(this.querySelector<HTMLElement>(':focus')); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ So I think the two different steps may be picking up typescript definitions. This patch should be removed after the issue is tracked down and fixed in a followup task. * fix: -Wnonnull warning Fixes this warning: > 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull] > 2025-03-07T01:05:01.8638267Z 257 | return nullptr; > 2025-03-07T01:05:01.8638481Z | ^~~~~~~ > 2025-03-07T01:05:01.8638700Z 1 error generated. Not sure why this warning was never triggered before; `git blame` indicates this code hasn't changed in ages: > c40a8273ef2 (Michaël Zasso 2024-05-10 09:50:20 +0200 255) #endif // DEBUG > 8e2d33f1562 (Anna Henningsen 2018-06-07 16:54:29 +0200 256) } > 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257) return nullptr; > 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258) } Presumably this is failing in this Chromium roll due to a clang version bump. We should remove this patch after upstreaming it. * docs: add upstream pr link for Node patch --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> (cherry picked from commit 458b14b) * chore!: bump chromium to 136.0.7054.0 (main) (#45923) * chore: bump chromium in DEPS to 136.0.7054.0 * chore: update allow_in-process_windows_to_have_different_web_prefs.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5906158 patch applied manually due to context shear * chore: e patches all * refactor!: Session.clearStorageData(syncable) Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6309405 Remove syncable type from opts.quota in Session.clearStorageData(opts) because it that category has been removed upstream. BREAKING CHANGE: Removed ses.clearDataStorage({ quota: 'syncable' }) * docs: deprecate Session.clearDataStorage({ quota }) --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> (cherry picked from commit 20414f6) * chore: bump chromium to 136.0.7058.1 (main) (#45928) * chore: bump chromium in DEPS to 136.0.7056.0 * chore: update mas_avoid_private_macos_api_usage.patch.patch no manual changes; patch applied with fuzz * chore: update fix_adapt_exclusive_access_for_electron_needs.patch patch applied manually due to context shear 6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | https://chromium-review.googlesource.com/c/chromium/src/+/6319958 * chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch no manual changes; patch applied with fuzz 6311876: Expose captured surface resolution for MacOS | https://chromium-review.googlesource.com/c/chromium/src/+/6311876 * chore: e patches all * 6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | https://chromium-review.googlesource.com/c/chromium/src/+/6319958 * 6326673: views: Delete the single-parameter Widget::InitParams constructor. | https://chromium-review.googlesource.com/c/chromium/src/+/6326673 * https://chromium-review.googlesource.com/c/chromium/src/+/6331102 * 6331102: [A11yPerformance] Rename AXMode::kScreenReader to kExtendedProperties | https://chromium-review.googlesource.com/c/chromium/src/+/6331102 Sync with shell/browser/ui/webui/accessibility_ui.cc to upstream chrome/browser/accessibility/accessibility_ui.cc changes in 4af8657 * chore: bump Chromium 136.0.7058.1 (#45933) chore: bump chromium in DEPS to 136.0.7058.1 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> (cherry picked from commit b0c1137) * chore: bump chromium to 136.0.7062.0 (main) (#45957) * chore: bump chromium in DEPS to 136.0.7059.0 * chore: bump chromium in DEPS to 136.0.7060.0 * chore: bump chromium in DEPS to 136.0.7062.0 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> (cherry picked from commit 2de8fd7) * fixup! chore: bump chromium to 136.0.7053.1 (main) (#45906) chore: fix patch shear * chore: remove cherry-pick-521faebc8a7c.patch fixed upstream @ 521faeb 6334632: Disable setting primtive restart for WebGL in the cmd decoder. | https://chromium-review.googlesource.com/c/chromium/src/+/6334632 * chore: remove cherry-pick-9dacf5694dfd.patch fixed upstream @ 9dacf56 6330188: Move WebGL primitive restart state setting to the GPU process. | https://chromium-review.googlesource.com/c/chromium/src/+/6330188 * chore: e patches all --------- Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>

electron-roller Bot added no-backport semver/patch backwards-compatible bug fixes labels Mar 6, 2025

electron-roller Bot requested a review from a team as a code owner March 6, 2025 13:00

electron-cation Bot added the new-pr 🌱 PR opened recently label Mar 6, 2025

ckerr requested a review from a team as a code owner March 6, 2025 18:59

ckerr changed the title ~~chore: bump chromium to 136.0.7052.0 (main)~~ chore: bump chromium to 136.0.7053.1 (main) Mar 6, 2025

electron-roller Bot and others added 10 commits March 6, 2025 17:50

chore: bump chromium in DEPS to 136.0.7052.0

78b3bf6

chore: update mas_avoid_private_macos_api_usage.patch.patch

8b89b19

https://chromium-review.googlesource.com/c/chromium/src/+/6318359 patch applied manually due to context shear

chore: update preconnect_manager.patch

2667144

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6318420 patch applied manually due to context shear

chore: e patches all

33b9a14

chore: bump chromium to 136.0.7053.1

a471b1b

chore: update fix_remove_profiles_from_spellcheck_service.patch

e1619ce

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6326575 patch applied manually due to context shear

chore: e patches all

7dd6a32

chore: revert removal of v8 API used by Node.js

bfaa58a

devtools: Remove DevToolsUIBindings::SendJsonRequest() | https://chro…

f754ec1

…mium-review.googlesource.com/c/chromium/src/+/6326236

6244461: Merge //content/common/user_agent.cc into //components/embed…

94f55a8

…der_support:user_agent | https://chromium-review.googlesource.com/c/chromium/src/+/6244461

ckerr force-pushed the roller/chromium/main branch from 2a6f192 to 3ba94bc Compare March 6, 2025 23:54

ckerr reviewed Mar 7, 2025

View reviewed changes

ckerr added 8 commits March 6, 2025 21:58

6313744: Migrate views::Background factory methods to ColorVariant | h…

b873af0

…ttps://chromium-review.googlesource.com/c/chromium/src/+/6313744

6314545: Remove multiple argument support from base::ToString() | htt…

ada4b35

…ps://chromium-review.googlesource.com/c/chromium/src/+/6314545

6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab(…

b03cbd5

…) | https://chromium-review.googlesource.com/c/chromium/src/+/6317362

6308998: Add SettingAccess structured metrics event for DevTools | ht…

a0d6591

…tps://chromium-review.googlesource.com/c/chromium/src/+/6308998

6295214: Remove redundant state field in per-extension preferences | h…

9135f1a

…ttps://chromium-review.googlesource.com/c/chromium/src/+/6295214 NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc

docs: add upstream pr link for Node patch

7125f91

ckerr force-pushed the roller/chromium/main branch from e5bb750 to 7125f91 Compare March 7, 2025 03:58

ckerr added the roller/pause label Mar 7, 2025

ckerr reviewed Mar 7, 2025

View reviewed changes

deepak1556 approved these changes Mar 7, 2025

View reviewed changes

electron-cation Bot removed the new-pr 🌱 PR opened recently label Mar 7, 2025

dsanders11 reviewed Mar 7, 2025

View reviewed changes

codebytere mentioned this pull request Mar 7, 2025

refactor: remove usage of V8's {Attach|Detach}CppHeap() #45922

Merged

3 tasks

codebytere approved these changes Mar 7, 2025

View reviewed changes

ckerr merged commit 458b14b into main Mar 7, 2025

ckerr deleted the roller/chromium/main branch March 7, 2025 17:36

codebytere mentioned this pull request Mar 7, 2025

chore: add macOS 15.2 SDK electron/build-tools#702

Merged

ckerr added a commit that referenced this pull request Mar 12, 2025

fixup! chore: bump chromium to 136.0.7053.1 (main) (#45906)

e310c30

chore: fix patch shear

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump chromium to 136.0.7053.1 (main)#45906

chore: bump chromium to 136.0.7053.1 (main)#45906
ckerr merged 18 commits intomainfrom
roller/chromium/main

electron-roller Bot commented Mar 6, 2025 •

edited by ckerr

Loading

Uh oh!

ckerr Mar 7, 2025

Uh oh!

ckerr Mar 7, 2025

Uh oh!

ckerr Mar 7, 2025

Uh oh!

dsanders11 Mar 7, 2025

Uh oh!

release-clerk Bot commented Mar 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		This patch can be removed after an upstream fix lands in Node.js,
		e.g. in https://github.com/nodejs/node-v8/tree/canary

		Not sure why this warning was never triggered before; `git blame`
		indicates this code hasn't changed in ages:

Conversation

electron-roller Bot commented Mar 6, 2025 • edited by ckerr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ckerr Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

ckerr Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

ckerr Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

dsanders11 Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

release-clerk Bot commented Mar 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

electron-roller Bot commented Mar 6, 2025 •

edited by ckerr

Loading