Skip to content

fix: --inspect-brk hang when loading internal scripts#44132

Closed
deepak1556 wants to merge 1 commit into33-x-yfrom
robo/backport_inspector_fix
Closed

fix: --inspect-brk hang when loading internal scripts#44132
deepak1556 wants to merge 1 commit into33-x-yfrom
robo/backport_inspector_fix

Conversation

@deepak1556
Copy link
Copy Markdown
Member

@deepak1556 deepak1556 commented Oct 7, 2024 •
edited
Loading

Description of Change

Refs microsoft/vscode#230495
Upstream PR nodejs/node#54219

Release Notes

Notes: fix --inspect-brk hang when debugging with esm

@deepak1556 deepak1556 added target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. labels Oct 7, 2024
@deepak1556 deepak1556 requested a review from a team as a code owner October 7, 2024 15:26
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Oct 7, 2024
@deepak1556 deepak1556 added the semver/patch backwards-compatible bug fixes label Oct 7, 2024
@MarshallOfSound
Copy link
Copy Markdown
Member

MarshallOfSound commented Oct 7, 2024

Has this landed upstream, can you link the PR for reference?

@deepak1556
Copy link
Copy Markdown
Member Author

deepak1556 commented Oct 7, 2024

Yup, the patch has additional context and is a backport from upstream change. It will be available from v20.18.0

@deepak1556 deepak1556 changed the base branch from main to 33-x-y October 8, 2024 00:53
@deepak1556 deepak1556 requested review from a team as code owners October 8, 2024 00:53
@deepak1556 deepak1556 removed the target/33-x-y PR should also be added to the "33-x-y" branch. label Oct 8, 2024
@deepak1556 deepak1556 force-pushed the robo/backport_inspector_fix branch from 4416fb1 to 7a58f0e Compare October 8, 2024 00:55
@deepak1556 deepak1556 removed request for a team October 8, 2024 00:55
@deepak1556
Copy link
Copy Markdown
Member Author

deepak1556 commented Oct 8, 2024

Main is now on v20.18.0, retargeting.

@deepak1556 deepak1556 added the backport-check-skip Skip trop's backport validity checking label Oct 8, 2024
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Oct 8, 2024
@deepak1556
Copy link
Copy Markdown
Member Author

deepak1556 commented Oct 8, 2024

We have v20.18.0 rolls ongoing, closing this in favor of them.

/cc @jkleinsc

@deepak1556 deepak1556 closed this Oct 8, 2024
@deepak1556 deepak1556 deleted the robo/backport_inspector_fix branch October 8, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deepak1556 @MarshallOfSound