fix: node::loader::ImportModuleDynamically crash#41491
Merged
Conversation
MarshallOfSound
approved these changes
Mar 1, 2024
8e97350 to
cfb9c9d
Compare
ckerr
approved these changes
Mar 1, 2024
jkleinsc
approved these changes
Mar 1, 2024
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs nodejs/node#48510.
Resolves microsoft/vscode#206630
Fixes a crash in Node.js when dynamically importing inside of a Function. When running the scripts sequentially, the
Local<Script>created atsrc/node_contextify.cccan outlive theContextifyScriptsoImportModuleDynamicallymay crash because the ContextifyScript is released and the access can be invalid.Stacktrace
This is fixed in Node.js v20 and above, but wasn't backported upstream owing to the fact that it relies on two V8 commits that break Node.js ABI. However, we're ahead of Node.js' V8 version so we actually already have these commits.
cc @bpasero @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash that can result from some kinds of dynamic imports.