Skip to content

fix: do not call after() async_hook for asyncId 0#40574

Merged
codebytere merged 1 commit intomainfrom
update-async-hook-handling
Nov 22, 2023
Merged

fix: do not call after() async_hook for asyncId 0#40574
codebytere merged 1 commit intomainfrom
update-async-hook-handling

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Nov 21, 2023

Description of Change

Refs nodejs/node#41424

We need to keep our handling in ErrorMessageListener in sync with that in Node.js' createOnGlobalUncaughtException().

Fixing incidental to #40573, but that is unfortunately a separate issue.

Checklist

Release Notes

Notes: Fix a potential issue with async_hook corruption in some error contexts.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Nov 21, 2023
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Nov 21, 2023
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Nov 22, 2023
@codebytere codebytere merged commit e78ce82 into main Nov 22, 2023
@codebytere codebytere deleted the update-async-hook-handling branch November 22, 2023 16:37
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Nov 22, 2023

Release Notes Persisted

Fix a potential issue with async_hook corruption in some error contexts.

This was referenced Nov 22, 2023
Merged
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Nov 22, 2023

I have automatically backported this PR to "26-x-y", please check out #40592

@trop trop Bot added in-flight/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Nov 22, 2023
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Nov 22, 2023

I have automatically backported this PR to "27-x-y", please check out #40593

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Nov 22, 2023

I have automatically backported this PR to "28-x-y", please check out #40594

@trop trop Bot added in-flight/27-x-y in-flight/28-x-y merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/27-x-y labels Nov 22, 2023
@trop trop Bot added merged/26-x-y PR was merged to the "26-x-y" branch. and removed in-flight/28-x-y in-flight/26-x-y labels Nov 23, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
fix: do not call after() async_hook for asyncId 0 (electron#40574)
19fcdab 
fix: do not call after() async_hook for asyncId 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codebytere @zcbenz @deepak1556