Skip to content

fix: Node.js atob input validation#35415

Merged
zcbenz merged 1 commit intomainfrom
fix-atob-mismatch
Aug 25, 2022
Merged

fix: Node.js atob input validation#35415
zcbenz merged 1 commit intomainfrom
fix-atob-mismatch

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Aug 23, 2022

Description of Change

Closes #31018.

Cherry-picks

to fix inconsistencies between Node.js' implementation of atob and the WHATWG spec.

Checklist

Release Notes

Notes: Fixed a bug where calling atob in the renderer process could fail under some circumstances.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Aug 23, 2022
@codebytere codebytere requested review from a team as code owners August 23, 2022 09:17
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Aug 23, 2022
@codebytere codebytere changed the title fix: Node.js atob input validation fix: Node.js atob input validation Aug 23, 2022
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Aug 24, 2022
@zcbenz zcbenz merged commit 22ff2b6 into main Aug 25, 2022
@zcbenz zcbenz deleted the fix-atob-mismatch branch August 25, 2022 06:55
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Aug 25, 2022

Release Notes Persisted

Fixed a bug where calling atob in the renderer process could fail under some circumstances.

This was referenced Aug 25, 2022
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Aug 25, 2022

I have automatically backported this PR to "21-x-y", please check out #35443

@trop trop Bot mentioned this pull request Aug 25, 2022
Merged
@trop trop Bot removed the target/21-x-y PR should also be added to the "21-x-y" branch. label Aug 25, 2022
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Aug 25, 2022

I have automatically backported this PR to "19-x-y", please check out #35444

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Aug 25, 2022

I have automatically backported this PR to "20-x-y", please check out #35445

@trop trop Bot added in-flight/19-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/19-x-y labels Aug 25, 2022
@commit-lint commit-lint Bot mentioned this pull request Nov 16, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: Node.js atob input validation (electron#35415)
e26b823 
fix: Node.js atob input validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: ContextIsolation changes page behavior and breaks protonmail login

3 participants

@codebytere @zcbenz @miniak