Skip to content

chore: update nmv to 103 for Electron 18#31778

Merged
VerteDinde merged 1 commit intomainfrom
update-nmv
Nov 17, 2021
Merged

chore: update nmv to 103 for Electron 18#31778
VerteDinde merged 1 commit intomainfrom
update-nmv

Conversation

@VerteDinde
Copy link
Copy Markdown
Member

@VerteDinde VerteDinde commented Nov 9, 2021

Description of Change

This PR updates our NMV to 103 for Electron 18

Please do not merge until 17-alpha branch is created and this PR has been closed: nodejs/node#40768

Checklist

Release Notes

Notes: none

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Nov 9, 2021
@miniak miniak added semver/major incompatible API changes and removed semver/none labels Nov 10, 2021
@miniak
Copy link
Copy Markdown
Contributor

miniak commented Nov 10, 2021

@VerteDinde I believe this should technically be semver/major as it is a breaking change. I did that same for the previous bump #31282.

Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as changes requested so this doesn't accidentally get merged early.

@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Nov 17, 2021
@VerteDinde VerteDinde requested a review from jkleinsc November 17, 2021 19:33
@VerteDinde VerteDinde dismissed jkleinsc’s stale review November 17, 2021 19:34

17 was just branched, ready to merge!

@VerteDinde VerteDinde merged commit 3e71310 into main Nov 17, 2021
@VerteDinde VerteDinde deleted the update-nmv branch November 17, 2021 19:35
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Nov 17, 2021

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants