chore: update nmv to 103 for Electron 18#31778
Merged
VerteDinde merged 1 commit intomainfrom Nov 17, 2021
Merged
Conversation
miniak
approved these changes
Nov 10, 2021
Contributor
|
@VerteDinde I believe this should technically be |
zcbenz
approved these changes
Nov 10, 2021
jkleinsc
approved these changes
Nov 10, 2021
ckerr
approved these changes
Nov 10, 2021
jkleinsc
previously requested changes
Nov 11, 2021
Member
jkleinsc
left a comment
There was a problem hiding this comment.
Marking as changes requested so this doesn't accidentally get merged early.
17 was just branched, ready to merge!
|
No Release Notes |
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR updates our NMV to 103 for Electron 18
Please do not merge until 17-alpha branch is created and this PR has been closed: nodejs/node#40768
Checklist
npm testpassesRelease Notes
Notes: none