chore: bump chromium to 096e5313aaf19dfa0c4710145c34d (master)#26535
Merged
MarshallOfSound merged 74 commits intomasterfrom Dec 14, 2020
Merged
chore: bump chromium to 096e5313aaf19dfa0c4710145c34d (master)#26535MarshallOfSound merged 74 commits intomasterfrom
MarshallOfSound merged 74 commits intomasterfrom
Conversation
e6a2b1c to
8db9185
Compare
e8f1607 to
ecc0a56
Compare
2ae2663 to
0c42f3b
Compare
7f85700 to
712518e
Compare
abb400c to
cbe6cd3
Compare
It's been removed in newer Mantle versions and uses a deprecated enum
0700a43 to
899ef06
Compare
nornagon
reviewed
Dec 11, 2020
Comment on lines
+22
to
+29
| +class V8_EXPORT CppHeapCreateParams { | ||
| + public: | ||
| std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces; | ||
| + | ||
| + private: | ||
| + CppHeapCreateParams (const CppHeapCreateParams&) =delete; | ||
| + CppHeapCreateParams& operator=(const CppHeapCreateParams&) =delete; | ||
| }; |
Contributor
There was a problem hiding this comment.
This is very odd, are we sure this wasn't some hiccup that has now been resolved? Can we try removing this patch and see if the build still breaks?
Member
|
Stil failing without patch: see https://ci.appveyor.com/project/electron-bot/electron-ia32-testing/builds/36802786 |
6bd06dd to
899ef06
Compare
nornagon
approved these changes
Dec 14, 2020
MarshallOfSound
approved these changes
Dec 14, 2020
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Chromium to 096e5313aaf19dfa0c4710145c34d (master).
See all changes in ac06d6903a2c981ab90a8162f1ba0..096e5313aaf19dfa0c4710145c34d
Notes: no-notes