Conversation
_breakFirstLine was being set on the process, but that has changed in node 12 and so is no longer needed. Node will handle it properly when --inspect-brk is provided
deepak1556
reviewed
Apr 17, 2019
| root_extra_deps = [ "//electron" ] | ||
|
|
||
| # Registry of NMVs --> https://github.com/nodejs/node/pull/24114/files | ||
| node_module_version = 71 |
Member
There was a problem hiding this comment.
we are on v8 7.5 in master, but this number doesn't matter in master. I am thinking if we should have a gclient hook that pulls the right number from that json registry if one is available, which might be useful sanity check when we cut branches,
Member
There was a problem hiding this comment.
This number shouldn't be 71, it is in direct conflict with node. We should request another number in that JSON registry and set this to that number.
deepak1556
approved these changes
Apr 17, 2019
nitsakh
approved these changes
Apr 17, 2019
4 tasks
codebytere
approved these changes
Apr 24, 2019
|
Release Notes Persisted
|
3 tasks
MarshallOfSound
pushed a commit
that referenced
this pull request
Apr 29, 2019
* fix: add boringssl backport to support node upgrade * fix: Update node_includes.h, add DCHECK macros * fix: Update node Debug Options parser usage * fix: Fix asar setup * fix: using v8Util in isolated context * fix: make "process" available in preload scripts * fix: use proper options parser and remove setting of _breakFirstLine _breakFirstLine was being set on the process, but that has changed in node 12 and so is no longer needed. Node will handle it properly when --inspect-brk is provided * chore: update node dep sha * fix: process.binding => _linkedBinding in sandboxed isolated preload * fix: make original-fs work with streams * build: override node module version * fix: use _linkedBinding in content_script/init.js * chore: update node ref in DEPS * build: node_module_version should be 73
Contributor
|
A maintainer has manually backported this PR to "6-0-x", please check out #18044 |
1 similar comment
Contributor
|
A maintainer has manually backported this PR to "6-0-x", please check out #18044 |
MarshallOfSound
added a commit
that referenced
this pull request
Apr 29, 2019
* fix: add boringssl backport to support node upgrade * fix: Update node_includes.h, add DCHECK macros * fix: Update node Debug Options parser usage * fix: Fix asar setup * fix: using v8Util in isolated context * fix: make "process" available in preload scripts * fix: use proper options parser and remove setting of _breakFirstLine _breakFirstLine was being set on the process, but that has changed in node 12 and so is no longer needed. Node will handle it properly when --inspect-brk is provided * chore: update node dep sha * fix: process.binding => _linkedBinding in sandboxed isolated preload * fix: make original-fs work with streams * build: override node module version * fix: use _linkedBinding in content_script/init.js * chore: update node ref in DEPS * build: node_module_version should be 73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Upgrade to Node 12 on master branch.
Cherry-picks changes from #17752 and #17828, node module version uses 71.
Checklist
npm testpassesRelease Notes
Notes: Upgrade to Node 12