Fixed video being too long error.#993
Merged
JasonLovesDoggo merged 2 commits intoelebumm:developfrom Jul 14, 2022
thefinaloneg:length_issues
Merged
Fixed video being too long error.#993JasonLovesDoggo merged 2 commits intoelebumm:developfrom thefinaloneg:length_issues
JasonLovesDoggo merged 2 commits intoelebumm:developfrom
thefinaloneg:length_issues
Conversation
Contributor
|
this will be fixed in async webdriver if merged edit: great work tho |
efa2d19
approved these changes
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before, the code would check if the total length was too long after the last clip was added on, but not modify the entire video. My changes change the logic to also remove the last clip so the video will always be shorter than the specified limits.
Issue Fixes
This fixes issue #869 . Here is an example of before and after my commit.
I had specified a limit of 50 seconds for this video. Using the same post, and after my commit, this is the result.
Checklist:
Any other information (e.g how to test the changes)
None