Skip to content

Fixed video being too long error.#993

Merged
JasonLovesDoggo merged 2 commits intoelebumm:developfrom
thefinaloneg:length_issues
Jul 14, 2022
Merged

Fixed video being too long error.#993
JasonLovesDoggo merged 2 commits intoelebumm:developfrom
thefinaloneg:length_issues

Conversation

@thefinaloneg
Copy link
Copy Markdown
Contributor

@thefinaloneg thefinaloneg commented Jul 14, 2022

Description

Before, the code would check if the total length was too long after the last clip was added on, but not modify the entire video. My changes change the logic to also remove the last clip so the video will always be shorter than the specified limits.

Issue Fixes

This fixes issue #869 . Here is an example of before and after my commit.

image
I had specified a limit of 50 seconds for this video. Using the same post, and after my commit, this is the result.
image
image

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

None

@thefinaloneg thefinaloneg changed the base branch from master to develop July 14, 2022 20:15
Copy link
Copy Markdown
Collaborator

@JasonLovesDoggo JasonLovesDoggo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@efa2d19
Copy link
Copy Markdown
Contributor

efa2d19 commented Jul 14, 2022

this will be fixed in async webdriver if merged

edit: great work tho

@JasonLovesDoggo JasonLovesDoggo merged commit 8b2bac5 into elebumm:develop Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants