Skip to content

Corrected TikTok.py Max_Char Limited#1558

Merged
OpenSourceSimon merged 3 commits intoelebumm:developfrom
brian926:master
Apr 11, 2023
Merged

Corrected TikTok.py Max_Char Limited#1558
OpenSourceSimon merged 3 commits intoelebumm:developfrom
brian926:master

Conversation

@brian926
Copy link
Copy Markdown
Contributor

@brian926 brian926 commented Apr 11, 2023

Description

The max character is actually 200, not 300 per the documentation there is a server limit of 200 characters. This might be causing the 'error XXX.mp3 file not found' as the app splits based on max_char, and since this is 100 char over the limit the mp3 file never gets created.

Issue Fixes

'error XXX.mp3 file not found' when using TikTok TTS on comment's larger than 200 characters.

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

None

The max character is actually 200, not 300 per the [documentation](https://github.com/oscie57/tiktok-voice/wiki/Request-Parameters) `there is a server limit of 200 characters.` 
This might be causing the 'error XXX.mp3 file not found' as the app splits based on max_char, and since this is 100 char over the limit the mp3 file never gets created.
@brian926 brian926 changed the title Updated TikTok.py Corrected TikTok.py Max_Char Limited Apr 11, 2023
@OpenSourceSimon
Copy link
Copy Markdown
Collaborator

OpenSourceSimon commented Apr 11, 2023

I'll resolve the conflict. Thanks for the PR!

@OpenSourceSimon OpenSourceSimon merged commit 6cdc250 into elebumm:develop Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants