Corrected TikTok.py Max_Char Limited#1558
Merged
OpenSourceSimon merged 3 commits intoelebumm:developfrom Apr 11, 2023
Merged
Conversation
The max character is actually 200, not 300 per the [documentation](https://github.com/oscie57/tiktok-voice/wiki/Request-Parameters) `there is a server limit of 200 characters.` This might be causing the 'error XXX.mp3 file not found' as the app splits based on max_char, and since this is 100 char over the limit the mp3 file never gets created.
Collaborator
|
I'll resolve the conflict. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The max character is actually 200, not 300 per the documentation
there is a server limit of 200 characters.This might be causing the 'error XXX.mp3 file not found' as the app splits based on max_char, and since this is 100 char over the limit the mp3 file never gets created.Issue Fixes
'error XXX.mp3 file not found' when using TikTok TTS on comment's larger than 200 characters.
Checklist:
Any other information (e.g how to test the changes)
None