Merged
Conversation
Bumps [rich](https://github.com/Textualize/rich) from 12.5.1 to 13.3.1. - [Release notes](https://github.com/Textualize/rich/releases) - [Changelog](https://github.com/Textualize/rich/blob/master/CHANGELOG.md) - [Commits](Textualize/rich@v12.5.1...v13.3.1) --- updated-dependencies: - dependency-name: rich dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bump rich from 12.5.1 to 13.3.1
Fixed timeout error, add error for TikTok session ID if missing and improved return hinting
electro199
reviewed
Feb 3, 2023
Co-authored-by: Simon <65854503+OpenSourceSimon@users.noreply.github.com>
Better error handling and type hinting
Collaborator
|
rename to 3.1 |
fix: tts blending sentences between paragraphs
JasonLovesDoggo
requested changes
Feb 13, 2023
Collaborator
|
Add the pylint comment back @OpenSourceSimon |
Collaborator
Author
Oh okay sorry I forgot |
| if self._code == 4: | ||
| return f"Code: {self._code}, reason: the speaker doesn't exist, message: {self._message}" | ||
|
|
||
| if self._code == 5: |
Collaborator
There was a problem hiding this comment.
You could just use a hashmap and the code is the key
Collaborator
Author
There was a problem hiding this comment.
Yeah that is possible but I think this solution is fine. I don't think we need to overcomplicate this code
JasonLovesDoggo
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A couple of bug fixes
Issue Fixes